rehypejs/rehype-external-links

Change defaults to not add `target`, `rel` should just be `['nofollow']`

wooorm opened this issue 3 years ago · 2 comments

wooorm commented 3 years ago

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and couldn’t find anything (or linked relevant results below)

Problem

This plugin’s defaults behavior disagrees with reasonable web recommendations (https://css-tricks.com/use-target_blank/) accessibility recommendation (https://www.w3.org/TR/WCAG20-TECHS/G201.html), or precedence set by sites such as GitHub.

Solution

do not add target
rel should just be ['nofollow']

Alternatives

n/a

okikio commented 3 years ago

@wooorm #5 fixes this issue

👍1

github-actions commented 3 years ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.