rejetto/hfs

Folders shared with same name display path in VFS admin menu

Opened this issue · 3 comments

BEFORE

  • Are you using a reverse-proxy, like nginx?

Not using nginx or any proxy, also not applicable to the issue

To Reproduce

Add a real disk folder and leave the name the same as the terminal folder name (windows).
The VFS display in the admin panel shows the path rather than the name

Describe the bug

Note the "c:\" on the front of the name in the VFS list.

A picture is worth a thousand words ...
image

Expected behavior

I expected the name to be displayed without the path (c:\) in front of it.

Changing the name, including just changing the case of one letter, causes it to "do the right thing" and just display the name without the path.

image

The name should ALWAYS just be the name, no matter what. The path should NEVER be added automatically. Sure, if you want to copy the path to the name FIELD when a new item is added, fine (although I think that's a horrible default). But whatever is in the name field should be the unadulterated name in the list.

Screenshots

Inline above

Environment (please complete the following information):

  • OS: Win 10
  • HFS Version 0.52.9 (latest stable)
  • Browser chrome (N/A)

Additional context

None

this is just a misunderstanding.
As you say, you want the name to not include C:\ but in your screenshot that's exactly how it is in the NAME field.
You didn't experience a problem when browsing the files, you just expected to have a problem, right?
The VFS on the left is not strictly the name field. Look again, and see the name is displayed in normal color, while the C:\ is grayed out. The gray part is trying to be more informative on the configuration of the entry, so that in a small space i'm telling you both the name and the path.
Maybe using a smaller font for the gray part could be help telling there's a difference between the 2 parts?
like this
image

It's confusing because it displays the path sometimes but not others.
I'd say be consistent. Either always have the path or never put it there.

i see your point, and you may be right, but i'm not sure.
i'd like to get the opinion of more people on it, as i like it as it is.