rejetto/hfs

Crash during search for a large number of files.

Closed this issue · 8 comments

MsDming commented

BEFORE

  • Are you using a reverse-proxy, like nginx?
    • Check if your problem is caused by your proxy, try without it.
      No proxy.

To Reproduce
Steps to reproduce the behavior:

  1. Go to index page.
  2. Click on search button.
  3. Search a series of files using a keyword.
  4. Wait for minutes.

Describe the bug
The console will make an error and crash after searching for minutes.

Screenshots
捕获

Environment (please complete the following information):

  • OS: Windows10
  • HFS Version: 0.52.6、0.52.10
  • Browser: Edge
  • CPU: Intel Xeon E5-2630 v4
  • Memory: 32GB

Additional context
I find that HFS occupies about 4GB memory in the task manager when it crashed.
I manage a large number of files using HFS, this problem maybe related on my files number and computer configuration?

rejetto commented

hey,
first: the version i see in your screenshot has an important security problem. Update to 0.52.10 urgently.
Future versions will have automatic check for updates, and warnings for security problems (all optional).
The browser should not be involved in the problem.
In the past I've made tests with a lot of files, like +100k.
Making a similar test today, i see your same problem, so i guess something has changed for the worse.
I'll investigate this.

MsDming commented

Thanks for your quickly response!
This is the first issue I've submitted on GitHub, and I look forward to your fix.

rejetto commented

yeah, but this is not an easy one, i fear it may take a while :)

rejetto commented

so, there is a memory leak during the search.
it is supposed to go away as soon as the serach ends.
version 0.53.0 should mitigate this problem, by using less memory.
if you are lucky, you may even not see the problem anymore.
i'm still working on it for complete solution, tho.

rejetto commented

wow, this is tough.
i've already spent many hours on it, and i'm not done yet.

MsDming commented

oh, thanks for your updating, i'll try it : )
it's really a tough one.

rejetto commented

would you care to confirm the problem is fixed with this version?
hfs-windows-x64-0.54.0-alpha1.3.zip

i suggest that you enable the new option i just introduced
image
because a search in a big folder structure will be faster

rejetto commented

available in 0.54.0-alpha2