release-engineering/kobo

Add Django 1.11 to CI

rohanpm opened this issue · 3 comments

rohanpm commented

We should add some Django 1.11 configuration to the Travis CI. This would be needed to ensure the changes for issue #44 are working.

In scope:

  • There's at least one environment in tox.ini targeting Django 1.11
  • The environment is covered by Travis CI
  • The overall result of the test run for that new environment is successful
    • (This might require setting up some tests to xfail or skip.)
    • (If xfail is used, best to make them strict xfails, so that tests must be updated as bugs are fixed)

Not in scope:

  • Fixing all bugs or test xfails/skips needed for Django 1.11
alexandrevicenzi commented

@rohanpm if we add 1.11 we plan to drop support to versions before 1.9? If we drop anything before 1.9 or 1.8 we can cleanup some code. A while ago I was looking into the biggest changes and is not that difficult to migrate to 1.11 if we don't plan to have older versions (1.7 and 1.6).

I have some local changes that I should submit, it increases django 1.11 support.

rohanpm commented

@alexandrevicenzi at time of writing, tox.ini only covers Django 1.8. As far as I'm concerned any older Django version can already be considered as unsupported. Does that help?

I would not like to drop Django 1.8 support unless there's a specific reason (e.g. it's difficult/messy to have some piece of code working on both 1.8 and newer versions).

alexandrevicenzi commented

@rohanpm There's one piece of code that might be difficult to get working on any version before 1.10, but it needs future investigation.