release-it/release-it

Add support for Node 23

Opened this issue · 4 comments

ehmicky commented

If --engine-strict is used, npm install fails with:

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: release-it@17.10.0
npm error notsup Not compatible with your version of node/npm: release-it@17.10.0
npm error notsup Required: {"node":"^18.18.0 || ^20.9.0 || ^22.0.0"}
npm error notsup Actual:   {"npm":"10.9.0","node":"v23.1.0"}

If --engine-strict is not used, a warning is printed instead, but npm install does not fail.

webpro commented

We haven't tested it on Node.js v23 yet, feel free to do so.

bmish commented

For the record, it looks like this change from supporting all future Node versions to only the specified Node versions occurred here: 24b3ba6

What do you think is the best practice here?

Personally, I find it more convenient to include all future Node versions in the engines range, like eslint does for example:

https://github.com/eslint/eslint/blob/ee8c2200a19dd55aa5068b6cd336a2aec7c52ad3/package.json#L217

That makes it easier for consumers to install / run / test the package under all the latest / supported Node versions, without depending on every package to release an update to expand the range every six months.

  • 👍1
webpro commented

Agreed, Node.js is stable enough. Feel free to open a PR for this.

  • 👍1
  • 👀1
philippdormann commented

Personally, I find it more convenient to include all future Node versions in the engines range, like eslint does for example:

https://github.com/eslint/eslint/blob/ee8c2200a19dd55aa5068b6cd336a2aec7c52ad3/package.json#L217

That makes it easier for consumers to install / run / test the package under all the latest / supported Node versions, without depending on every package to release an update to expand the range every six months.

just opened a PR with this exact implementation