Older version of `jsdom` (<23) causes deprecation warnings
stephenlrandall opened this issue · 5 comments
Initial checklist
- I read the support docs
- I read the contributing guide
- I agree to follow the code of conduct
- I searched issues and couldn’t find anything (or linked relevant results below)
Affected packages and versions
rehype-mathjax
Link to runnable example
No response
Steps to reproduce
Install rehype-mathjax with npm/pnpm/yarn
Expected behavior
No deprecated warnings
Actual behavior
The following deprecation warnings (pnpm):
WARN 2 deprecated subdependencies found: abab@2.0.6, domexception@4.0.0
Both of these are used by older versions of jsdom (<23), but have been removed in jsdom v23 after being deprecated.
Runtime
No response
Package manager
pnpm
OS
macOS
Build and bundle tools
Vite
Welcome @stephenlrandall! 👋
Warnings are not necessarily a bug, it still works and is secure 🙂
That said a PR upgrading JSDom to latest would also be welcome.
Yeah, I wasn’t sure exactly what to classify this as. I’d be happy to provide a PR — I assume that all packages use this dependency, and there’s some test suite that should pass?
I assume that all packages use this dependency
only the rehype-mathjax package https://github.com/search?q=repo%3Aremarkjs%2Fremark-math%20jsdom&type=code
there’s some test suite that should pass?
Yes, running npm test runs a test suite, static analysis tools, and a type checker.
@ChristianMurphy Opened #94. All tests passed.
Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.