remcohaszing/monaco-yaml

Support deprecated decorator for json schema

Resetand opened this issue · 4 comments

Resetand commented

The case is pretty simple, seems like json schema supports a "deprecated" arrtibute – http://json-schema.org/draft/2019-09/json-schema-validation.html#rfc.section.9.3

"type": "object",
  "properties": {
    "property": {
      "description": "I have a description"
    },
    "deprecatedProperty": {
      "deprecated": true
      "description": "This property is deprecated, please use a 'property' field"
    },

In this case i want to strike-through this property, like

Screenshot 2022-10-30 at 13 38 17

Resetand commented

As far as i know, monaco editor supports a Deprecated tag for markers

Screenshot 2022-10-30 at 13 41 47

remcohaszing commented

I would like this too, but it needs to be fixed upstream in json-languageservice. See microsoft/vscode-json-languageservice#87.

I'm closing this as it's not actionable from this repository.

florentchauveau commented

Hello there! It has been fixed upstream microsoft/vscode-json-languageservice#87 by microsoft/vscode-json-languageservice#133. May we re-open this? 🙏

remcohaszing commented

I'm glad this is fixed upstream, but there's no need to re-open this. It will be fixed once yaml-language-server updates vscode-json-languageservice so monaco-yaml can update.

  • 👍1