remind101/slashdeploy

Locking is case sensitive

Closed this issue · 4 comments

xfontro commented

Locking a repository to an environment is case sensitive. E.g.:
Locking production on acme-inc/repo_name, won't lock a deployment to production on Acme-inc/repo_name. This may lead to unfortunate deployments on environments that should be locked.

A solution to this could be to treat the repo as case insensitive, normalizing it to minor case.

Related issue: #50

russellballestrini commented

I can't reproduce, when I try to do this, it throws an error:

I don't know about any environments for remind101/Empire. For details about configuring environments, see https://slashdeploy.io/docs.

Note our repo is empire not Empire

xfontro commented

Executing the following should reproduce it:

/deploy lock test-capitalized on remind101/Empire
/deploy lock test-uppercase on remind101/EMPIRE
/deploy lock test-all-uppercase on REMIND101/EMPIRE

/deploy where REMIND101/EMPIRE should now only return test-all-uppercase as a known environment.
And the same with deployments, in this case a deployment to remind101/empire won't be locked.

Tell me if there is any issue with reproducing it this way, I'll try to answer ASAP. Thanks

russellballestrini commented

@xfontro are you using the latest version of SlashDeploy? (A version that defines environments using .slashdeploy.yml)?

xfontro commented

Yes, I was using an old version, defining the environments on the config file should solve this. Closing the issue, thanks!

  • 👍1