remirobert/Dotzu

Decouple NSKeyArchiver from StoreManager.swift

johndpope opened this issue · 3 comments

johndpope commented

further to investigation
remirobert/Dotzu-Objective-c#4

I drafted this code for your review
https://gist.github.com/johndpope/1dd3663a8712bb1901536a44bccd6a5a

this way - if we can get this into core library,
I can over ride this with any library that conforms to logging protocol,

protocol LogProvider {
func archiveLogs(logs: [T])
func storedDataForKey(key:String)->NSData?
func logs() -> [T]
func reset()
}

johndpope commented

when my app starts - there's so much rapid logging - it takes dotzu logger some time to catch up.
need to fix this. If I open a PR - will you consider merging?

wwe-johndpope commented

@remirobert - this library is conflicting with another library that is unhooking the following hooks.

-> LoggerCrash.unregister()
this is called - even though - register is never called.
NSSetUncaughtExceptionHandler(nil)
signal(SIGILL, SIG_DFL)
signal(SIGABRT, SIG_DFL)
signal(SIGFPE, SIG_DFL)
signal(SIGBUS, SIG_DFL)
signal(SIGSEGV, SIG_DFL)
signal(SIGSYS, SIG_DFL)
signal(SIGPIPE, SIG_DFL)
signal(SIGTRAP, SIG_DFL)