remorhaz/php-json-path

Better name for NodeValueFactory

Closed this issue · 3 comments

remorhaz commented

Current class name NodeValueFactory may sound confusing for users without intimate knowledge of library internals. Maybe DocumentFactory will sound better? In fact, most users will use this class to instantiate JSON document before applying query to it.

nicoseijas commented

JSONDocumentFactory?

remorhaz commented

Thank you for your opinion! JSON is already part of namespace, and I thought that "document" in context of JSON-processing library is clearly a "JSON document" by default.

remorhaz commented

The class have moved to remorhaz/php-json-data, and so does the issue.