Google Drive _getFile doesn't check if a file ID exists before using it
stuartlangridge opened this issue · 1 comments
stuartlangridge commented
In _getFile at
remotestorage.js/src/googledrive.ts
Line 476 in 5b580e8
remotestorage.js/src/googledrive.ts
Line 477 in 5b580e8
https://www.googleapis.com/drive/v2/files/undefined
which is definitely wrong.
This isn't a PR because I'm not sure what should happen here; should that function throw an error, or fake a response object with statusCode 404, or something else?
raucao commented
This isn't a PR because I'm not sure what should happen here; should that function throw an error, or fake a response object with statusCode 404, or something else?
Faking a 404 seems like a reasonable option to me. I guess any potential issues with that approach would become apparent once you implement and test it.