Refactor repeat_start needed

Question

Refactor repeat_start needed

Opened this issue 5 years ago · 3 comments

When a robot fails to enter a ready state, it should not say the boot message. That is to say, when a robot fails to authenticate, it should not continue saying "OK" until it's killed.

This appears to be somewhat addressed in networking.py, however I've failed to observe the termination actually terminating; although it may be an overzealous repeat_start starting the script after it's terminated, I'm not quite sure.

Answer 1 · 2019-11-21T02:03:18.000Z

This is in part because the boot message is in the internetStatus function, and not actually linked to the bot authenticating to the site. I was surprised when you added a customized boot message that you did not move it somewhere more appropriate.

The other reason is repeat_start. The internet status function runs by default at 120 second intervals, so unless it's been dropped to something unreasonably low, the controller is being terminated and restarted and thus repeating the message.

Answer 2 · 2019-11-21T02:07:33.000Z

I haven’t yet looked through the code to see the absolute best spot for it. I’ll do that when I get home, but am also open to suggestions. Currently sitting in the lobby of a Red Robin waiting for somebodies food, trying to ignore the Vengaboys on the speakers.

Answer 3 · 2019-11-21T05:14:03.000Z

Looks like it's actually an issue with repeat_start. Not sure what to do about that...