remy/mit-license

Link not Working - Application Error

DhrumilShah98 opened this issue ยท 10 comments

I created my page using the generator tool but it is not working. I get the Application error when I visit the page.

Link to my JSON file - dhrumil-amish-shah.json

Can I know the fix?

I'm in the same boat. I'd appreciate it if you got around to fixing this.

My JSON file: ajdepaul.json

@remy What do the logs say?

It seems like the user files had never been redeployed and the site failed the load the fallback.

remy commented

@Richienb it looks like the error we've had before:

2021-09-02T09:51:37.640091+00:00 app[web.1]: (node:33) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'license' of undefined
2021-09-02T09:51:37.640100+00:00 app[web.1]: at getRoute (file:///app/routes/get.js:77:44)
2021-09-02T09:51:37.640163+00:00 app[web.1]: (node:33) UnhandledPromiseRejectionWarning: Unhandled promise rejection.


I'm having the same issue, although idk if it's bc I haven't waited long enough

remy commented

@Richienb I've been looking into this and wrote a decent test and only when the tests pass did I think to check the last deploy date on the project. For reasons beyond me (at the moment) Heroku hasn't been deploying this - the last deploy was in June. Around 200 license files aren't on Heroku.

I'm going to kick the Heroku connection to see if I can get it going again, but at the least it should resolve the latest questions.

remy commented

@Richienb bit more context, I suspect Heroku was waiting for CI to pass, and I can now see that Travis (where the tests were) froze some months ago (I'm guessing June). So I've disabled the check for the moment to get deploys working again, and I'll move CI into github actions and then re-enable.

remy commented

All others on this ticket - your license pages are working now ๐Ÿ‘

@remy I copy-pasted a GitHub Actions config that I have lying around into the project and it appears to work.

remy commented

I saw you're using the npm over yarn (which I can't remember how yarn got into this project, but I'm happy with, we should make a package-lock.json file too and swap it for the yarn lock file - or update the commands in the action config).