renecotyfanboy/jaxspec

Use the TLMIN/TLMAX keywords in OGIP Files

renecotyfanboy opened this issue · 4 comments

renecotyfanboy commented

See https://heasarc.gsfc.nasa.gov/docs/heasarc/caldb/docs/memos/cal_gen_92_002a/cal_gen_92_002a.html

TLMIN and TLMAX provides the lower and higher index when reconstructing the rmf matrix, and should be included in jaxspec

sguillot commented

That'll teach me to bring up potential problem to you!
I'll stay quiet next time

  • 😄1
renecotyfanboy commented

ahah don't worry, I'll take care of this and ping you for the review only

renecotyfanboy commented

@sguillot you might be interested in 3ML implementation of OGIP file reader

renecotyfanboy commented

As discussed, I stole the implementation from 3ML especially here. The keyword is now considered when reading an RMF file. You might want to look at this commit

  • ❤️1