renovatebot/pep440

Remove strange string exports

viceice opened this issue ยท 8 comments

What would you like to be able to do?

Remove these exportes, as they aren't easily usable via esm imports

pep440/lib/operator.js

Lines 12 to 18 in 5fb26d3

"<": lt,
"<=": le,
"==": eq,
"!=": ne,
">=": ge,
">": gt,
"===": arbitrary,

Did you already have any implementation ideas?

Simply remove them. Probably breaking.

@rarkins WDYT? I't not used by renovate or pep440 code.

@viceice We should keep it I think as there are 250+ developers using the package and they might be using it.

Where do you got the info from?

My bad. ๐Ÿ˜… The information used to be on the landing page for @renovate/pep440.
I also hope I didn't confuse it with Renovate's users.

I only see one used by, maybe there where more before renaming ๐Ÿคทโ€โ™‚๏ธ

We can leave this for now, as it's very low prio.

We can't make types of them, so they probably won't be usable by typescript projects.

Happy to remove these in a major bump

can't easily removed:

const op = Operator[spec.operator];

needs refactoring ๐Ÿ˜•

bmeck commented

these exports are usable via recent ESM https://262.ecma-international.org/13.0/#prod-ModuleExportName just use:

import { "==" as eq } from "pep440"