renovatebot/renovate

Ansible-galaxy datasource : enable the customRegistrySupport

Closed this issue · 9 comments

lutin-malin commented

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.6.12

Please select which platform you are using if self-hosting.

Bitbucket Server

If you're self-hosting Renovate, tell us what version of the platform you run.

N/A

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

According the the galaxy documentation, a declared collection can specify its own source.

[My] use case : a self hosted galaxy server hosting private collections.

here could be an example :

#requirements.yml
---
collections:
  - name: awx.awx
    version: 19.0.0
    source: [my internal galaxy server]

At runtime, the specified source is ignored, and fallback to hardcoded value 'https://galaxy.ansible.com/'
https://github.com/renovatebot/renovate/blob/main/lib/modules/datasource/galaxy-collection/index.ts#L22

which leads to unretreived version values.

Relevant debug logs

Logs 
 WARN: Custom registries are not allowed for this datasource and will be ignored (repository=[my repo])

Have you created a minimal reproduction repository?

No reproduction repository

rarkins commented

So are the custom sources extracted correctly by the manager but then ignored by the datasource?

lutin-malin commented

So are the custom sources extracted correctly by the manager but then ignored by the datasource?

yes, out of the shelf !

rarkins commented

In that case this might work if we just set the custom registry flag from false to true

lutin-malin commented

that's what i did locally, and it is working 'almost' well.

Remains a typo with the registry url for which the trailing backslash is removed( ... )

github-actions commented

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

TheLastProject commented

Am I correct in understanding this issue also affect git clones? We seem to be suffering from something similar:

{"name":"renovate","hostname":"<removed>","pid":8,"level":40,"logContext":"<removed>","repository":"<removed>","datasource":"git-tags","registryUrls":["git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker"],"defaultRegistryUrls":null,"msg":"Custom registries are not allowed for this datasource and will be ignored","time":"2023-04-18T08:53:54.136Z","v":0}

With the following requirements.yml:

collections:
  - name: community.docker
    source: git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker
    type: git
    version: 2.7.5
viceice commented

Am I correct in understanding this issue also affect git clones? We seem to be suffering from something similar:

{"name":"renovate","hostname":"<removed>","pid":8,"level":40,"logContext":"<removed>","repository":"<removed>","datasource":"git-tags","registryUrls":["git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker"],"defaultRegistryUrls":null,"msg":"Custom registries are not allowed for this datasource and will be ignored","time":"2023-04-18T08:53:54.136Z","v":0}

With the following requirements.yml:

collections:
  - name: community.docker
    source: git@gitlab.<removed>:<removed>/mirrors/ansible-collections/community.docker
    type: git
    version: 2.7.5

no, that's a different issue on the manager. please open a new discussion for that

renovate-release commented

🎉 This issue has been resolved in version 37.69.0 🎉

The release is available on:

Your semantic-release bot 📦🚀