renovatebot/renovatebot.github.io

Merge confidence image hosted on GitHub not rendering in published docs

HonkingGoose opened this issue · 5 comments

HonkingGoose commented

What browser are you using?

Firefox

Other browser name

No response

Describe the bug

I added a screenshot to the readme.md file for the "Merge Confidence" docs. You can see the screenshot when you view the readme.md on GitHub, but you can't see the screenshot on the published page.

The alt text "Renovate PR with Merge Confidence badges" is visible on the published page though, and it's in an <img> element, the src= property points to the correct place as well. So at least something is rendering... 🙈

Steps to reproduce

  1. View the readme.md source file on GitHub -> image present.
  2. Now view the published page Renovate docs, Merge Confidence -> image missing.

Additional context

View the Renovate docs, pinning dependencies and lock files, the images are working properly there.

The images that work are in the main Renovate repo under docs/usage/assets/images.

I'm not sure why it works when images are under docs/usage/assets/images and it breaks when I link to an external image on GitHub.

rarkins commented

Is the image URL it points to correct? And if so then it's a matter of that the image is missing?

viceice commented

image
url is pointing to repo and returns wrong

This PR should fix the url

  • 👍1
viceice commented

image
works 🎉

  • 👍1
  • 🎉1
HonkingGoose commented

Thank you @viceice for fixing the link!

I didn't know that CORB was blocking the image from displaying. So next time I want to link to images on GitHub, I should use https://raw.githubusercontent.com/ as the domain. 😄

viceice commented

your url was pointing to the GitHub blob view, which is a html page, that only works on github ui, because it's replaced server side. so you - need to use the raw button to get the right url.

  • 👍1