renpy/vscode-language-renpy

Some colors chaged and I don't now why

JoaoGW7 opened this issue Β· 14 comments

Extension version

2.2.0

Issue description

When I first started the visual studio today, then I was required to reaload the studio, I did it and idk know why, but everything was different, now the variables are red and before it wasn't.

The persistent. variables are now half red half white. The screen atributes are with no theme, I don't have any screenshots from before but I think you guys got it.

code

I tried to use on my notebook after relising this and there it was normal, then again, I was required to reaload the studio and for the cience I did, and the colors was different again ;-;

Idk if someone can help me with this, and I now it sounds like nothing but I was with those colors for years and now they are just different.

(I am using "The Best Theme" theme, link)

This is the first submit here so if was missing any info, my bad πŸ₯²βœŒπŸ»

Scope inspector screenshots

frame:
    xysize(720, 720)
    background "gui/ui/background.png"
    foreground "gui/ui/foreground.png"
    xalign 0.5
    yalign 0.5

Code

frame:
    xysize(720, 720)
    background "gui/ui/background.png"
    foreground "gui/ui/foreground.png"
    xalign 0.5
    yalign 0.5

Hi @JoaoGW7 . Today we have released a new version in which we use a new grammar, that's why now the variables have a different color. The color depends on the theme you are using.

Hi @JoaoGW7 . Today we have released a new version in which we use a new grammar, that's why now the variables have a different color. The color depends on the theme you are using.

But how can I set like it was before? I tried to download the old version but nothing changed ;-;
Also I didn't changed the theme or any setting.

We'll try to fix the issue as soon as we can. With your help it will go even faster :)

Can you post a screenshot of the half red issue you mentioned?

The highlighting of the frame block I will fix soon

We'll try to fix the issue as soon as we can. With your help it will go even faster :)

Can you post a screenshot of the half red issue you mentioned?

The highlighting of the frame block I will fix soon

Sure πŸ˜„! Really thanks btw.

image

Idk if I was clear about this before, but thats it.

image

Another example about the screen atributesπŸ‘†πŸ»

Your current theme uses the color red for variables. The reason why some are red and some are not colored, is because we don't currently support semantic highlighting for nested variables. This is a feature we have been working towards, but will still take a while before it's in.

Just to confirm, what is the color of a label in your label statements?

label whats_my_color:

The ATL language blocks are missing in some other block statements as well (eg. vbox and some screen an style statements). ATL has been added somewhat recently. But as you may know, ATL was actually not supported in the previous version :)

Now they are blue:

image

Here are some screenshots I found from how it was BEFORE (they are from mouths ago, so I can't make a "before and after"):

image
image
image
image

And here are some more screenshots from hot it is NOW:

image
image
image
image
image

I tried to send with similar codes. As you can see, just a bit different, but more then I would handle ;-;

Also, thanks for the fast answer, and sorry for anything πŸ˜„βœŒπŸ»πŸ‡§πŸ‡·

Ah, I see what's going on there. I'll get those fixed too. Not sure if I have time to fix them all today, but I'll fix them ASAP

Fix is on the way. Once it's merged and @LuqueDaniel has made a new build, it should be available to you. Please let me know if you have any additional issues with that new version

Will this new "fix" resolve the new borked issue in code when {size=-xx} is used? Currently using the size text tag with a negative value causes the color to whack out as if there was a missing quotation mark on standard text. Regards.

Will this new "fix" resolve the new borked issue in code when {size=-xx} is used? Currently using the size text tag with a negative value causes the color to whack out as if there was a missing quotation mark on standard text. Regards.

Yes, it should

Updated it again and it is much better now, really thanks bros. The colors isnt the same as before but I think I can fix it 😁😁😁

Thanks bros, amazing work S2

Updated it again and it is much better now, really thanks bros. The colors isnt the same as before but I think I can fix it 😁😁😁

Thanks bros, amazing work S2

Could you tell me what you currently dislike about the color scheme? We made most changes to the color theme to improve readability and context.

Any feedback is welcome, it might improve the experience for everyone :)

Just some small things, like:

"imagebutton", "button" and actions on screens are without colors.
image

Some text styles on screens are different, like the "text _()" color and "vbox" are the same as the styles, also, the "outlines" style is without colors and the "size" is 🫠
image

Beside those small things it is everything fine and I liked the others colors changes, I was working normally yesterday and it was normal (which is great ✌🏻)

Hi there, I added highlighting for these (key)words.
Though please note that screen language was kinda hacked in to get it sort of working.

I hope this will be a much better experience for you. Let me know if there are any other issues.