Autocomplete up and down arrow keys don't work in example configuration

Question

Autocomplete up and down arrow keys don't work in example configuration

Closed this issue 2 years ago · 5 comments

Update your dev environment to have the latest CM6 packages. yarn upgrade should do it
Start the development environment and open the dev page in a browser
Place the cursor on the last line of the document and type 'c' so that the autocomplete menu pops up
Press the down arrow key. Nothing happens. It should move the highlight onto the next item in the autocomplete menu.

The reason this happens is that the Emacs bindings use a DOM keydown handler rather than a CM6 keymap, and in CM6, either all keymaps are run before the DOM handler or all keymaps are run after the DOM handler. In the default configuration, and indeed any useful configuration, we have the latter. The problem is that the autocomplete arrow key bindings, which have the highest precedence within keymaps, are never run because the Emacs DOM handler handles arrow keypresses first and swallows them.

masad-frost commented 2 years ago

hmm.mp4

Answer 1 · 2022-10-04T21:28:10.000Z

I'm not observing this behavior. You can see that here https://codemirror-emacs.util.repl.co/

Answer 2 · 2022-10-05T07:44:13.000Z

I suspect your dev environment hasn't got the latest CM6 packages then. I should have added that step, and I have now.

Answer 3 · 2022-10-05T18:58:59.000Z

I see, you're right. It breaks in 6.3.0

Answer 4 · 2023-03-13T18:20:15.000Z

@nightwing are you able to help get #5 merged?

I think we need to migrate both of these libraries to use the CM6 keymap functionality. This issue reproduces with some combination of a local build + CM6 package versions.