_log_batch function in ReportPortal service class no longer takes item_id as its parameter
sanathpholla opened this issue · 2 comments
Describe the bug
Previous to the commit mentioned below, the log_batch function was taking item_id as parameter and the log was attaching to that particular item_id specified. But since this commit, item_id is removed from _log_batch function making it impossible to attach the batch log to particular item_id.
29200b0#diff-a76d396c04c4c11ad4bb41b1b9b37f04acdceaa2e6423620cf5b9bff48053f0a
Steps to Reproduce
NOT REQUIRED
Expected behavior
_log_batch function should have item_id parameter added back. And the logs should be attached to item_id if it is given
Actual behavior
_log_batch function does not take in a parameter called item_id hence attaching batch logs to an item_id is not possible
Package versions
Latest Master/eng code
Additional context
Would like to have item_id parameter back into _log_batch function
cc: @iivanou
@iivanou Could you please help in getting this resolved. Happy to create a PR to address this changes. Pl let me know.
@sanathpholla, Methods which start with the underscore are not supposed to be used outside the class. Use the log method instead. Log batches mechanism is used by default now.