reportportal/client-Python

`max_pool_size` not worked without `retries` setting

ericz15 opened this issue · 2 comments

Describe the bug
I am encountering an issue where HTTPAdapter.pool_maxsize seems to be limited to 10 even when using the newest version of ReportPortal. The expected behaviour is for HTTPAdapter.pool_maxsize to be set to the default value 50, as specified in ReportPortalClient construction.

Steps to Reproduce
When starting any test cases with ReportPortalClient v5.2.5, I noticed that the HTTPAdapter.pool_maxsize did not change.

Expected behavior
The HTTPAdapter.pool_maxsize should be 50, which is the default value for ReportPortalClient construction.

Actual behavior
Looking through the code, I discovered that HTTPAdapter.pool_maxsize seems to be capped at 10. Here's where it occurs:

I want to clarify if there are any concerns about this usage. Is it possible to increase the size of max_pool_size without setting retries?

Thank you, and I look forward to your reply.

Package versions
reportportal-client: 5.2.5

@zhangzheng1214 service.py is deprecated and doesn't mean to be updated: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/service.py#L3

If you update client.py, then I can approve the fix, but I don't want to touch service.py in any case.

@HardNorth Thank you for your response. I have reverted the changes made in service.py and added some code to client.py. Could you please review it when you have a chance?