repository-preservation/lcmap-pyccd

ccd.detect returns empty change models on Test Data

caffeine-potent opened this issue · 3 comments

ccd.detect doesn't seem to be working on your test data.

Here is the output that I'm getting:

{'algorithm': 'lcmap-pyccd:1.1.0', 'change_models': [], 'procedure': 'standard_procedure', 'processing_mask': array([False, True, False, True, True, False, False, True, False, True, True, True, True, True, False, False, False, True, False, True, False, False], dtype=bool)}

I would suggest reformatting the test data such that there is little chance that my "Formatting it to make it work in python" is the source of error.

I've made a PR that makes the contents of TestData.md copy-paste-able in python. Can someone review If my formatting is correct? #15

I realize now that:

the observation count for the sample data is 11,
while the meow_size is 12

I would recommend posting better sample data.

Unit testing and documentation were unfortunate victims of a short development cycle. There are plans to rectify these situations, especially as evaluation of the algorithm results is undertaken internally.

So, I would just hold on for now on this.