requests/toolbelt

SourceAddressAdapter with certain port should be stricter with pool size and blocking?

n1ngu opened this issue · 0 comments

n1ngu commented

As far as I understand, if SourceAddressAdapter is used with an (IP, PORT) tuple and the port is other than 0, there is no way this adapter can work without passing

pool_connections=1,
pool_maxsize=1,
pool_block=True,

to the underlying HTTPAdapter.

Shouldn't this either

  • be forced by the implementation
  • raise a warning if this exact values are not specified by the user
  • write more documentation about it

?