rescrv/HyperLevelDB

Minor issues with version_set.cc

Closed this issue · 2 comments

HowardHinnant commented
  1. The function IntSetToString is unused. This is also an issue with leveldb.
  2. On line 556 the local variable sum is unused. The construction of sum appears to use significant computation without any side effects.
  3. On line 1499, the local variable largest is unused.
rescrv commented

Ideally, I'd like these flags to all be enabled without warning, but it would drift too far from upstream: https://github.com/rescrv/HyperDex/blob/master/m4/anal_warnings.m4

rescrv commented

I'll close when fixed.