rescrv/libmacaroons

pyx function signature error

Closed this issue · 1 comments

wesc commented

Apologies, I haven't dug into this so I don't know if this is a trivial fix or not. I get this error when trying to build:

vagrant@wesdev:~/libmacaroons$ make
make --no-print-directory all-am
  PYX    bindings/python/macaroons.c

Error compiling Cython file:
------------------------------------------------------------
...
        MACAROON_NOT_AUTHORIZED   = 2055
        MACAROON_NO_JSON_SUPPORT  = 2056

    macaroon* macaroon_create(unsigned char* location, size_t location_sz, unsigned char* key, size_t key_sz, unsigned char* id, size_t id_sz, macaroon_returncode* err)
    void macaroon_destroy(macaroon* M)
    int macaroon_validate(const macaroon* M)
                                       ^
------------------------------------------------------------

bindings/python/macaroons.pyx:55:40: Expected ')', found '*'
make[1]: *** [bindings/python/macaroons.c] Error 1
make: *** [all] Error 2

Am I missing something?

Older Cython versions (0.12 for sure, not sure about others) didn't support the const qualifier. I recommend using a newer version, or stealing the %.pyx:%.c files from the shipped tarballs. I know 0.20 supports const qualifiers.