reservoirprotocol/marketplace-v1

[UI] Issues and links incorrect on Optimisim & Polygon

timothycarambat opened this issue · 1 comments

While understanding that the current support for Optimism and Polygon is limited, we should take efforts to try to generalize all UI elements to work with their associated chain so as new chain support is rolled out, the transition is painless.

Some issues discovered when trying to create a marketplace for an Optimism contract:

  1. Marketplace links are incorrect.
  • Looksrare does not support Optimism.
  • The links for OS now specify the chain and when not specified assume ETH, which may not always be true.

Screen Shot 2022-10-07 at 2 55 08 PM

Links in the image above:
  1. Support for other marketplaces like Quix.app (Primary Optimism Marketplace) and showing X2Y2 listings for other chains would be nice to see in the token view.

  2. The social URLs for Blockexplorer always assume Ethereum (etherescan.io) where this changes depending on the chain of contract.

  3. On the collection page Hero image the API_BASE for non-ethereum chains at redirect/currency/${address}/icon/v1 does not return a current image and in this case, we should fallback to something rather than show the 'image missing placeholder'

Screen Shot 2022-10-07 at 2 56 47 PM

Thanks for submitting this PR! We're going to spend some time over the next few weeks to polish up the marketplace for polygon (and future proof for additional chain support). Closing out this PR for now.