Update all links to resonate.is and resonate.coop to use the SITE_DOMAIN env variable
jackhajb opened this issue · 7 comments
Tasks
- Update all links that reference
resonate.is
andresonate.coop
to use theSITE_DOMAIN
env variable. - Create a fallback for the
SITE_DOMAIN
variable that will useresonate.coop
- Double check all updated routes for the links using the
SITE_DOMAIN
work properly on the new site. The new site can be tested atresonate.space
. e.g. https://resonate.coop/the-coop is broken if you go to route onresonate.space
, https://resonate.space/the-coop, it instead needs to be updated to ``https://resonate.space/coop` .
Do not modify any community.resonate.is
links
some items seem to only exist on resonate.is
/stream/beta/assets/manifest.json
for example: https://static.resonate.coop/pwa_assets/icon-128x128.png
images from the albums:
https://upload.resonate.is/images/046cb430-1680-4dc4-a5c2-7378eb250ae2-x120.jpg
does not exist at
https://upload.resonate.coop/images/046cb430-1680-4dc4-a5c2-7378eb250ae2-x120.jpg
https://resonate.coop/join redirects to https://resonate.is/join
Maybe this could be split into updating API stuff and updating non-API stuff?
I found the APP_HOST env var in this repo, which seems to be doing the same thing. Could we use that ?
Line 3 in f314a36
@whatSocks @mcfiredrill Sorry for the confusion here, the goal is to update the site links.
The APP_HOST variable is for the streaming player which is different from the website.
Let me know if that adds clarity
@whatSocks @mcfiredrill Sorry for the confusion here, the goal is to update the site links.
The APP_HOST variable is for the streaming player which is different from the website.
@jackhajb
Ah right, for the new website correct?
https://github.com/resonatecoop/website
Hello,
trying to help with this.
I am currently looking at the components/footer/index.js
-file.
Am I understanding it correctly that for instance in this file you want to edit the link to the About
Section from
${link({ prefix: 'link mid-gray pa0 lh-copy',
text: 'About',
href: 'https://resonate.coop/about',
target: '_blank'
})}
to something like
${link({ prefix: 'link mid-gray pa0 lh-copy',
text: 'About',
href: process.env.SITE_DOMAIN+'/about',
target: '_blank'
})}
This solution is for the streaming site (this repo) and would currently give us the link: resonate.localhost/about (with SITE_DOMAIN defined in the /base/.env file) WITHOUT "https://"
So I think it's a good solution as long as we can put https:// in the SITE_Domain variable in .env - is that acceptable?
${link({ prefix: 'link mid-gray pa0 lh-copy', text: 'About', href: process.env.SITE_DOMAIN+'/about', target: '_blank' })}
Hey @caprenter, yes, I think that would be acceptable (apologies for the delayed response).