retrixe/decaffeinater

compiling on windows doesn't run "npm install"

Closed this issue · 8 comments

When compiling for windows, electron-builder doesn't install app dependencies in app/ automatically before creating the executable.. workaround would be to create a custom build script which can detect and solve the issue..

would like to add that this may also be the case on macOS but I have yet to be able to provide macOS compiles because they do not produce on Linux .-.

This is not the issue on macOS, macOS builds are now automated by travis ci.

Re-assigning this to the 2.0 milestone.

Solution: Python scripts for build and compiles, Also, #9

Actually, this issue is dead thanks to webpack, but now we have #9. Cya

e6ae304 was supposed to bundle a fix for semantic-ui-css, but an error has displaced that. Wait for next commit. We will incorporate CSS with webpack, at which phase, this is a dead issue.

ff59e52
Issue done for.

A newer commit requires the semantic-ui-css to be user upgraded, which is perfect because no need for having breaking changes in the code.