psbtsigner should return a json
Closed this issue · 7 comments
Either we make it default or at least we add an option to return a json object, this way it's easier to use in scripts :)
Yes.
On a more general note i'm a bit worried with augmenting and patching psbtsigner. It was initially, and still is in some way, a hack that i used locally for my manual testing and just ended up committing there for reviewers to use too. If we need something we should probably opt for something more generalistic. Especially in scripts, one could extend the Python support in the test framework and separate it in a script.
For the manual testing part, maybe contributing signing support to https://github.com/stevenroose/hal would be preferable?
So Sanket implemented that in Hal! stevenroose/hal#25 🎉
Should we remove the psbtsigner altogether?
Yeah, it was meant as a temporary hack. I haven't used it in months, and looks like Hal can do basically the same (and if it doesn't we can just contribute a small tweak there). I'm for removing it.
@edouardparis do you have any use for psbtsigner or we can remove it?
No use for me 👍