fail_on_error flag is not working as expected
dmchandru opened this issue · 1 comments
dmchandru commented
My workflow config file as follows
jobs:
eslint:
name: runner / eslint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: eslint
uses: reviewdog/action-eslint@v1
with:
reporter: github-pr-review # Change reporter.
workdir: 'src/'
fail_on_error: true
Initially the runner was reported the status check as failed if the PR code have any lint issues. But now the status check seems to passed even if the code have lint issues.
plata commented
Can confirm:
- yml
- commit: PhoenicisOrg/scripts@0e7c1ef
You can see that the error got reported but the action still passed. I only noticed it because I'm still using Codacy as well.