revsys/django-tos

Pypi Package supporting Python 3 and up

Closed this issue · 6 comments

floese commented

Hi and thanks for your work on this.
Are there any plans to release the python >= 3 supporting code of this respository in a pypi package? Or are there reasons that this hasn't happened? As I'd imagine it to be more comfortable for users of this package to be able to include it to a project by using a official pip installable release.

frankwiles commented

I'm confused, the version that is released support Python 3. In fact, it's currently only tested against Python 3.7 - 3.10 https://github.com/revsys/django-tos/blob/master/.github/workflows/django.yml#L15-L42

floese commented

Thanks for getting back.
I just installed the django-tos package v1.0.0 via pip to retest. There's an occurence of unicode() in models.py (line 76) which is deprecated since Python 3.0. This leads to an error when (e.g.) trying to access the User Agreements Model in the django admin site.
In the master branch of this repository this has been fixed in December 2022. The latest release on pypi seems to be from February 2022.

nicholasserra commented

Ah, makes sense. Probably don't have test coverage hitting that line.

@frankwiles looks like we need a version bump and pypi release of the latest changes on github whenever you have a moment, and we should be good to go

frankwiles commented

ok I just released 1.10 to pypi with the changes. Thanks!

  • 👍1
nicholasserra commented

Thanks! Do you have a commit pending with the version bump?

frankwiles commented

Yes, good catch. I committed it but forgot to push when I got distracted by the next shiny object. It's there now.

  • 🎉1