reziamini/migrator

Arrow function but Composer allows PHP 7.3

Closed this issue · 1 comments

ash-jc-allen commented

Hey! When I was just making a PR, I noticed that in src/Service/StructureParser.php on line 32, the line is:

return array_filter($this->structure, fn($value) => !is_null($value['type']));

This line uses an arrow function and (as far as I'm aware) these can only be used on PHP 7.4 upwards. However, the composer.json file looks like it allows PHP 7.3.

I'm guessing the composer.json just needs changing to make PHP 7.4 the minimum? Or just switching the arrow function back to a closure if you want to keep support for 7.3? I'm happy to make a PR for either if needed :)

reziamini commented

Thank, it was fixed!

  • 👍2