rezozero/starting-blocks

Naming inconsistency

notorigine opened this issue · 2 comments

notorigine commented

Regarding the new Transition feature, I think it would be convenient to apply the naming convention that's being used in starting-blocks where jQuery objects get prefixed with $

Example: this.oldContainer, this.newContainer should be named this.$oldContainer and this.$newContainer as they are jQuery object

Gouterman commented

Yes you right ! But in the next major version, we are going to remove jquery

Gouterman commented

Fix with new 5.0.0 release :)

  • 🎉1