macOS: modification and creation dates reset
alexanderharm opened this issue · 35 comments
I started using gocryptfs (latest version) on macOS High Sierra and noticed that each time I eject my encrypted volume and remount it, that the creation and modification dates are reset to 1970-01-01. Is this expected behaviour?
I mount my dirs using
gocryptfs -ko local /path/to/encDir /Volumes/encDirAlso mounting them without the -ko local option has the same result.
Huh. What happens to the dates of the encrypted files?
The date of the metadata file (?) is correct, the date of the data file is also reset.
When you write to a file, the encrypted file stays at 1970?
For a very brief moment it shows the correct datetime but after max. one second it is reset.
Well, that's funny. I'll see if I can get my hands on a macos box next week to reproduce this.
I the meantime, can you run gocryptfs with
"-fg -nosyslog -fusedebug"
an see what happens when you modify a file?
I don't see anything unusual but then I don't have a clue about this :-)
gocryptfs.log
Maybe found it. Can you try this build? gocryptfs.gz
gocryptfs v1.4.4-29-g996d2f1 without_openssl; go-fuse v20170619-32-g4ff4497; 2018-04-29 go1.10
I tried and noticed the following:
- Mounted decrypted new file: creation date still 1970, modification date: fine
-
Encrypted new file: both dates seem to look fine
-
BUT: I cannot modify existing files anymore (see attached screenshot)
Ok, thanks for testing! So the problem is where I though it is, but the fix is causing other problems
Well, thank you for all your efforts and prompt replies. Really appreciated!
Ok, I have that Mac box. And I can reproduce the save-existing-files problem: Happens in TextEdit as well, but does not seem to be related the fix. Also happens with older gocryptfs versions.
On the command line, writing files works fine, so it seems to be that the MacOS GUI file save functions seem to be unhappy about something.
Did you use the Homebrew version? Because with the latest version from Homebrew I don't have any problem apart from the file dates, never had. So I cannot confirm that it also happens with older gocrypt versions, at least not on my systems.
Ok it seems that xattr support is what causes the The file is locked problems. This is not yet released and not yet in homebrew. Change fe38906 should fix this, care to test the new build (attached)?
Tested the build and it works for me. However, creation date is still 1970-01-01 but all the rest works fine!
Just to let you know, this needs fixing in the go-fuse library and will take some time, step one is this: hanwen/go-fuse@bb848eb
Indeed, this can take a while. Any chance of getting your "fixed" version into Homebrew. Somehow I don't feel comfortable that I published a non-working version there... And I have to come back to ctime because I don't see it addressed anywhere. Any chance of getting that fixed as well?
The "some time" this will take are probably two weeks. The issue is not too serious, and I believe it only affects High Sierra users. This is also why it was not noticed before. Things are mostly working, I don't think we need to rush out a fix.
ctime: yes, I will try to get this fixed as well!
I think High Sierra is the worst bug-fix/maintenance release ever...
Well, maybe, but in that case, the bug is in gocryptfs / go-fuse ;)
Does this one fix the creation time issue? gocryptfs.gz
Unfortunately not.
Thanks. The good news is, I have reproduced it here:
$ stat b/Untitled.rtf
855638233 4572339 -rw-r--r-- 1 user group 0 375 [...] "Jan 1 01:00:00 1970" 131072 2048 0 b/Untitled.rtf
The bad news is that this is unfixable, as FUSE has no support for file creation ("birth") time.
Struct fuse_attr just does not have a field for it: https://github.com/libfuse/libfuse/blob/21b55a05a158b1c225ba312529bc068cadd5431d/include/fuse_kernel.h#L158
Anyway, I'll keep this ticket open until the timestamp fixes are merged into go-fuse.
According to the author of osxfuse this should not be an issue:
FUSE for macOS sends FUSE_GETXTIMES messages to your user space file system daemon. You need to reply with the creation time. I don't know how this is handled by the Go library you are using. But this is definitely no t a limitation of FUSE.
Thanks for finding out! Not supported at the moment by either gocryptfs or go-fuse, though. This is a mac-specific extension of the FUSE protocol.
I know, but maybe we can get hanwen to implement it in go-fuse...
Maybe another day...
Fix was merged into go-fuse (hanwen/go-fuse@76c2303), I'll close the issue.
Released as v1.5
is this problem still under work?
I´ve seen yesterday that all my files unter macOS have the creation date 1.1.1970.
The encrypted-folder is fine/works but the files in the mounted folder show the wrong creation date :-(
The original problem was fixed in gocryptfs 1.5. You see the same problem again? Which gocryptfs and macos version?
@rfjakob I think he talks about the birth date issue. In version 1.5 you fixed the modification dates.
@warmup72 Nope, afaik no one tackled it. The problem is not in gocryptfs but in hanwen/go-fuse, see hanwen/go-fuse#218. According to the author of osxfuse this should be an easy fix but I didn't manage since I lack the skills. It would be great if someone could tackle this because I rather like gocryptfs but I also started using cryptomator since that one also supports versioning (and you don't get the complaints about unsupported volume when using Number, Pages etc.
I´m using 1.7 on macOS 10.14.4
Yes, as I said the creation date is set to 1970:
Mounted Path
stat ./data/*
905969707 12897042013 -rw-r--r-- 1 Simon staff 0 264826 "Apr 9 18:05:16 2019" "Dec 4 16:03:39 2018" "Apr 9 14:54:24 2019" "**Jan 1 01:00:00 1970**" 131072 2048 0 ./data/181204_180012_OSRAM_LED_STAR_PAR16.pdf
905969707 12895479981 drwxr-xr-x 4 Simon staff 0 128 "Apr 14 10:35:07 2019" "Mar 17 16:46:35 2019" "Mar 17 16:46:35 2019" "**Jan 1 01:00:00 1970**" 131072 2048 0 ./data/Neuer Ordner
905969707 12897042014 -rw-r--r-- 1 Simon staff 0 2171559 "Apr 14 14:51:38 2019" "Nov 20 10:03:00 2017" "Apr 9 14:54:24 2019" "**Jan 1 01:00:00 1970**" 131072 6144 0 ./data/eHZ_Stromzähler_Produkthandbuch.pdf
encrypted Path
stat ./crypt/*
16777220 12897042014 -rw-r--r-- 1 Simon staff 0 2188569 "Apr 14 14:51:38 2019" "Nov 20 10:03:00 2017" "Apr 9 14:54:24 2019" "**Nov 20 10:03:00 2017**" 4096 4280 0 ./crypt/9GYIE_K6h2D4GVfJNfPfOzWwB6MDlNnHSMxzvbBCm3wpKkdiwTTRp1YLYyGLkKGV
16777220 12895479981 drwxr-xr-x 4 Simon staff 0 128 "Apr 14 10:35:07 2019" "Mar 17 16:46:35 2019" "Mar 17 16:46:35 2019" "**Mar 17 16:46:35 2019**" 4096 0 0 ./crypt/lMsNrys1ZotFOcRU5lDvKg
16777220 12897042013 -rw-r--r-- 1 Simon staff 0 266924 "Apr 9 18:05:16 2019" "Dec 4 16:03:39 2018" "Apr 9 14:54:24 2019" "**Dec 4 16:03:39 2018**" 4096 528 0 ./crypt/uLmlTA1sPWA8fr3yDA9X6fMVLZBmLItn9KCgwo17PzNyo2ewOkqRIKQmfewCgbg4
BTW: I also tried cryptomator but they didn´t support tags which I need for my DMS
Maybe this issue should be reopend?
Could you create a new one? I would prefer that, as the modification time issue was fixed already.