Add support for Rails 6
KeithP opened this issue · 9 comments
Need to assess what if anything needs changing to enable dependency to be bumped up to activerecord 6.0.0.
change log: https://github.com/rails/rails/blob/master/activerecord/CHANGELOG.md
Is this going to happen soon?
Wanting to move to 6.0 rc1
thanks
any news about it?
+1
Is this just not tested on Rails 6 or it doesn't work? Because currently it doesn't work for sure :) due to the dependency restriction. But from your comment it seems like it only hasn't been tested. I think the better approach would be to write in the readme to use with Rails 6 with caution and then you might also get much better error reports from people testing stuff in Rails 6.
It's also to say in the readme:
Version 5.x supports ActiveRecord 5.1+
This led me to believe version 5 supports Rails 6 as well.
So, what's the proposed workaround for the time being? Fork the project and just change the dependency restriction? :/
EDIT: Just saw the Rails 6 PR. I'll stick to that until it gets merged into master.
Still not working for 6.0.0.rc2. Any suggestion please ?
8: from /usr/local/lib/ruby/gems/2.6.0/gems/activesupport-6.0.0.rc2/lib/active_support/dependencies.rb:322:in require' 7: from /usr/local/lib/ruby/gems/2.6.0/gems/activesupport-6.0.0.rc2/lib/active_support/dependencies.rb:288:in load_dependency'
6: from /usr/local/lib/ruby/gems/2.6.0/gems/activesupport-6.0.0.rc2/lib/active_support/dependencies.rb:322:in block in require' 5: from /usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:34:in require'
4: from /usr/local/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:123:in rescue in require' 3: from /usr/local/lib/ruby/2.6.0/rubygems.rb:216:in try_activate'
2: from /usr/local/lib/ruby/2.6.0/rubygems.rb:223:in rescue in try_activate' 1: from /usr/local/lib/ruby/2.6.0/rubygems/specification.rb:1418:in activate'
/usr/local/lib/ruby/2.6.0/rubygems/specification.rb:2302:in `raise_if_conflicts': Error loading the 'postgis' Active Record adapter. Missing a gem it depends on? Unable to activate activerecord-postgis-adapter-5.2.2, because activerecord-6.0.0.rc2 conflicts with activerecord (~> 5.1) (LoadError)
Just want to point out that Rails 6 final was released today.
How close are we to having a Rails 6 compatible release? Is there anything the community can do to help support this release?
There is an PR #300 from https://github.com/corneverbruggen/activerecord-postgis-adapter/tree/activerecord-6.0 which failed the tests right now. Hopefully the author will fix the test so it can be merged