rhomobile/rhomobile-docs

Geolocation.set_notification_ex docs out of sync with reality (iOS)

jtara opened this issue · 2 comments

jtara commented

5.0.38 docs state:

Ruby: Geolocation.set_notification_ex(callback url, string callbackParams, options hash)

JavaScript: Rho.Geolocation.set_notification_ex(callback url, string callbackParams, options hash);

iOS implementation punts by simply calling set_notification. But mis-match in type of third parameter:

void rho_geo_set_notification_ex(const char *url, rho_param* p, char* params) {
    //TODO: rho_geo_set_notification_ex
}

IMO, this is a bug, and I will file an Issue for that.

But the documentation should correspond with reality. At least a note about the bug. It should be stated that this is not implemented for iOS.

Don't know about other platforms.

jtara commented

I wasn't very observant!

It doesn't punt to set_notification. It does nothing, and of course will still throw a run-time error if the third parameter is a hash.

Definitely should be documented as "not implemented" for iOS!