[enhancement] - Config options safety check
mcanoy opened this issue · 4 comments
📝 Description
Users provide values for Team Name, Cluster Name and Git Server.
A common error users make is to insert https:// in front of the Git Server and Cluster Name. It would be nice if in the js we detected the value and stripped out the invalid part
Line 41 in 3f0145f
Bonus 🏆: Strip out all characters than make an invalid url
ha ! its a trick .. to see if you read the very first page of the instructions ...
would be nice to validate the input though .. i.e. don't let you enter it in the wrong format, rather than strip it
If this week's pilot is a good indication, we had 100% success rate on this TIP message being missed. Even though it was called out before the technical exercise started + showed on screenshare during a mobbing session - all before ex 1 started.
PR ready for mergé. Would be good to touch base with you guys once you've done your pilot. We're doing two back to back in March / April so feedback and thoughts should be gathered 📦
I made this mistake too. Because i grabbed the url from the location bar and then pasted in to the box. So didn't noticed the lead up.
yeah - ideally do a ping to the urls and get a 200 back. but stripping out will do.