rhysd/Shiba

Each errors are hidden, can't be seen whole.

Closed this issue · 14 comments

koron commented

Can't see tail of messages on Windows.

shiba-error

It would be better pop up whole message when mouse cursor on it.

rhysd commented

I tried this with Shiba's README.md but it didn't reproduce 😭

default

Could you tell me the OS version? (although I guess Windows10)

rhysd commented

Ah, I got it. The drawer is expanded

rhysd commented

I tried with full window width to expand drawer, but it still did not reproduce 😭😭

default

The scrollbar is shown properly in my environment (Windows 8.1).

rhysd commented

As a workaround, setting drawer non-responsible may be available to avoid this issue.

Putting config.yml as below

drawer:
    responsive: false
koron commented

Sorry my late response.

I met this for https://github.com/vim-jp/syntax-vim-ex/blob/master/README.md in Windows 10 env.
I'll test your suggestion later, please wait it.

rhysd commented

Thanks! I'll also test with the README.

If you can, I'll happy to see the DOM (and CSS values applied to the drawer) with DevTools.
(In Windows, Alt key -> Click 'Shiba' -> Click 'DevTools' will launch DevTools.)

koron commented

Please verify my screen cast.

01

My operations are as you expected?

koron commented

Can't see tail of messages on Windows.

It means file name and line number.
Body of error message is shown whole.
(But it does not seem as good messsages 😉)

rhysd commented

Yes, correct! Thank you for so plain screenshot 😸

It looks that the scroll issue occurs only when the drawer is expanded.

It means file name and line number.

Yes, that's right. I should fix this as another issue...

  • 👍1
rhysd commented

Sorry, I misunderstood this issue. You wrote 'Each errors are hidden'.

You mean below message has lost its tail?

List item should be loose, isn't

koron commented

I was going to have reported two things.

  1. filename and line number is hidden.
  2. It looks like that some kind of important info was removed from List item should be loose, isn't

Sorry for ambiguous notation.

rhysd commented

Thank you for making it clear.

filename and line number is hidden.

This was fixed in #29, thank you for reporting.

It looks like that some kind of important info was removed from List item should be loose, isn't

Actually that's all of message from linter.

$ remark syntax-vim-ex-README.md -u remark-lint

syntax-vim-ex-README.md
        1:1   warning  Do not mix casing in file names                no-file-name-mixed-case
   6:1-6:43   warning  Headings should use setext                     heading-style
  9:36-10:1   warning  List item should be loose, isn’t               list-item-spacing
  11:39-12:1  warning  List item should be loose, isn’t               list-item-spacing
  12:48-13:1  warning  List item should be loose, isn’t               list-item-spacing
  15:1-15:15  warning  Headings should use setext                     heading-style
  19:1-19:18  warning  Headings should use setext                     heading-style
  21:1-26:4   warning  Do not use dollar signs before shell-commands  no-shell-dollars
  37:78-38:1  warning  List item should be loose, isn’t               list-item-spacing
  38:52-39:1  warning  List item should be loose, isn’t               list-item-spacing
  40:64-41:1  warning  List item should be loose, isn’t               list-item-spacing
  44:1-44:17  warning  Headings should use setext                     heading-style
  46:1-49:4   warning  Do not use dollar signs before shell-commands  no-shell-dollars
  51:1-51:11  warning  Headings should use setext                     heading-style
  55:1-55:11  warning  Headings should use setext                     heading-style

⚠ 15 warnings

Exactly the ... is't message looks weird...

rhysd commented

@koron

Can we close this?

koron commented

👍 thanks!