rib/gputop

gputop-ui host/port option

Closed this issue · 1 comments

eero-t commented

Test-case:

  1. run as root: GPUTOP_PORT=80 gputop
  2. run as proposed by gputop: gputop-ui -h 127.0.0.1:80

Expected outcome:

  • goutop-ui connects to server

Actual outcome:

  • gputop-ui didn't split port number from IP address, used a default port number, and couldn't connect

If gputop-ui has an option for specifying port number, gputop server should specify correct one.

IMHO "-h" option should be reserved for command line help, not for specifying gputop-ui host address.

-> It would be better if all the tools would use same command line options for consistency. E.g. gputop-wrapper uses "-H" for host and "-p" option for port number.

djdeath commented

I was lazy and left this out for the glfw ui...
Should be trivial to fix.