Remove composer.lock from git repository
Closed this issue · 1 comments
ek9 commented
I believe the composer.lock
file should not be part of this repository. The reasons being:
- The
CI
should always run against latest versions of the package. As that is what any new user installing the package will get. This will make sure that we see any kind of breaking due to version updates early and can update our version constraints incomposer.json
file accordingly. composer.lock
is a common source of conflicts when developing / doing PRs, thus it becomes problematic as you need to rebase a lot of PRs if this file is updated.- Generally it's ok to include
composer.lock
in projects, but as this is more of a library/tool that is fetched and used by other users, thencomposer.lock
should not be included in the repository. (Read more @ http://stackoverflow.com/a/24247443 )
ek9 commented
I've just realised this is gone already. Closing.