richinfante/satellite-rs

Test for inaccuracy?

Opened this issue · 1 comments

rirze commented

Hi,

I was looking through your README and I saw this statement:
Deep-space calculations appear to be slightly off. Cause is currently unknown

How are you arriving at this conclusion? I've run the tests but they all pass. There is one test under dpper where you do an assert_similiar-- is this what you mean by the accuracy being slightly off?

I would like to investigate this issue and fix it if possible. If I know how to validate the precision, I can work to resolve it.

There's a couple tests (where I used assert_similar) where they're off by a bit more than I expected due to floating-point math errors, and still haven't quite figured out the source yet. I'm not a subject-matter expert so I'm not too sure the impact of this on actual use

It's possible they're all working fine - the test cases were generated using the javascript implementation so the issue may be on that end and not in this library at all