License Issues

[singletongue]

Hi, I'm @singletongue, a maintainer of the cl-tohoku/bert-japanese.

Thank you for sharing your great work.

However, I'm a little concerned that some parts of your code src/corpus/build_pretrain_dataset.py are possibly taken from our code make_corpus_wiki.py.
Since we are releasing our codes under the Apache License 2.0, It might be better if you adopted the same license, not the MIT license.

Thank you.

[ZHAOTING]

Hi @singletongue! Many thanks for your group sharing the code for bert-japanese.

Indeed we have adopted part of your Wikipedia dataset construction code, and I am sincerely sorry for not conforming to the same license. We will take action soon and update our codebase with an easy-to-see update message.

Best

[singletongue]

Thank you for your swift response, @ZHAOTING.
I appreciate your action regarding this issue.
I'm glad that our codes are utilized for open-source projects like yours.

Best regards

[ZHAOTING]

@singletongue -san, in order to comply with the Apache 2.0 redistribution requirements, we have to 1) keep the original license claim in the adopted file/code, and 2) explicitly note the modification.

Therefore, would you please add a short license claim comment (like this ) at the beginning of your make_corpus_wiki.py file, so that we are able to use the exact same claim in our modified file?

[singletongue]

Thank you for your response, @ZHAOTING.

I have prepended the license claims to the codes.
https://github.com/cl-tohoku/bert-japanese/blob/main/make_corpus_wiki.py

[ZHAOTING]

@singletongue Our license has been updated. And an update log has been added to README.
Could you please check if you are okay with the current license situation and close this issue if things look fine?

Thank you!

[singletongue]

I have checked the license and README and confirmed that everything should be fine.
I appreciate your swift response.

Thank you!