rinvex/laravel-subscriptions

Update to support Laravel 8

hgferreira opened this issue · 15 comments

Hi,

Is it possible to update to support Laravel 8? It should be a quick fix.

Thank you!

wimil commented

same....

same

Djuki commented

+1

Up up

nivv commented

I've added a pull request, there are no tests, and I have not tested the package after the updates. #118

+🥰

any updates?

nivv commented

any updates?

Project seems dead. I'd look for a replacement, or fork it and maintain it yourself

any updates?

project seems dead. I'd look for a replacement, or fork it and maintain it yourself

okay thanks

I don't belivie it is dead. Well, at least the main reason, which is abandon the project. The author don't give the proper attention for years and his updates after months are LIKE "well... now I want php 7.4, just because it looks good, if you want..." (#90, #98)

First off, what i did, i wrote an kind email directly to rinvex without a response.

In case it could help anyone too. Here is my solution which has a few downsides and is not perfect at all.

  1. Modify your composer.json
"autoload": {
        "psr-4": {
....
            "Rinvex\\": "support/rinvex"
        },
    },
  1. Create a directory /support/rinvex or anything you would like
  2. Move the src Code from rinvex packages into their corresponding directory ( /support/rinvex/Categories|Subscriptions|Support)
  3. Decide if you want to keep rinvex model validation (I removed it). You might have to do some more work here too to get it working (e.g. you'll need another third party dependency)
  4. Integrate every dependency that any rinvex package use in your composer.json (like spatie/laravel-sluggable, kalnoy/nestedset, ...)
  5. Run your tests, if you don't have any, write them.

My win for this solution, i don't have to modify my existing source code and can leave it, as it is. For instance, i'm mostly subclassing package models like seen below

<?php

namespace App\Shared\Models;

class Category extends \Rinvex\Categories\Models\Category
{
}

I don't like this approach but when rinvex comes back i can easily switch back and re-run my tests.

Good luck everyone in surviving this nightmare

Hello, thank you for your patience, this is now done! Check latest release!!

This package now supports Laravel v8, PHP v8, Composer v2, enjoy 🥳

CC @mojtabaahn @schranzer235 @insign @bassem-shoukry @nivv @schranzer235 @alikemalcivelek @masitings @Djuki @Crisis2010 @wimil @hgferreira