rio-labs/rio

`Checkbox` Border Color When `is_on = False` Should Default to Secondary Color

Closed this issue · 8 comments

When is_on = False for the Checkbox component, the border color defaults to black. For better visual consistency, the border color should match the color of the filled checkbox, such as the secondary color by default.

image image

/attempt

I disagree with this. Having checkboxes light up even when disabled seems like way too much visual clutter. It's also not in line with the reference material design checkboxes.

image

Finally, I'd argue this lowers consistency, as switches also turn gray when disabled

am i suppose to work on it?
@Sn3llius

@Nirajan1-droid I discussed this internally with mad-moo, and he has already fixed the issue, as demonstrated in his picture.

Thanks for the update.
will keep an eye out for issues to contribute in the future.

Thanks! I'll be adding some new issues in the coming days, so there might be something of interest for you.

We're also still missing radio buttons. If you're interested, that could be a great task for you. I'll open a feature request for it. While it isn't our highest priority, it would be a huge help!
https://m3.material.io/components/radio-button/overview

ok great