Use container header on all consumers

Question

Use container header on all consumers

Closed this issue 4 years ago · 5 comments

Description

This PR demonstrates the usage of the container-ripe#title which should be applied to all other places where we have a duplicated container-header class.

@todo we need to add more information and implementation guidelines

Answer 1 · 2020-05-08T08:00:52.000Z

@NFSS10 let's add header-buttons to the container before closing this.

Answer 2 · 2020-05-08T08:10:05.000Z

@NFSS10 let's add header-buttons to the container before closing this.

Working on it !

Answer 3 · 2020-05-13T16:22:56.000Z

@NFSS10 is this Doing or In Review?

Answer 4 · 2020-05-13T19:40:22.000Z

@NFSS10 is this Doing or In Review?

@gcandal "Doing", as it still needs to be decided what to do with the header-buttons in details-ripe when in mobile

Answer 5 · 2020-05-16T11:45:33.000Z

@gcandal We really need to talk about this issue as a whole as this is a p-low issue that is creating a lot of PRs and work. On top of that, this issue was not properly validated by myself on triage. Let's use the Monday timeslot to re-discuss this one. I believe we can find a good compromise that both improves the current solutions and avoid a lot of disruption :)