ripe-tech/ripe-sdk

ripe-sdk doesn't work with RequireJS

marcomontalbano opened this issue · 4 comments

marcomontalbano commented

ripe-sdk seems doesn't work on projects that use RequireJS.
We are upgrading ripe-sdk from 1.2.4 to latest version (1.6.25), but we encounter this issue:

ripe-sdk requirejs

I notice that between 1.2.4 and latest version the if statement has been changed.
I tried putting back the old one

if (typeof window === "undefined" && typeof require !== "undefined") {
  ...

and it works.

Could you check this?
Thanks

gcandal commented

@marcomontalbano we'll look into it, thanks for reaching out as well as investigating the issue.

joamag commented

@marcomontalbano this issue should now be fixed, going to create a new release

joamag commented

@marcomontalbano Please try version 1.6.26 and let us know if everything is working.

marcomontalbano commented

@joamag I can confirm you that version 1.6.26 is working fine with RequireJS. Thanks!