API masks with the total image size
dsafonso opened this issue · 5 comments
Description
When the get the compose on white we receive always the image with 1000x1000, but the masks we receive always with the size we on the build.
Example: brand=dior_tmp & model=book_tote the images are 2000x2000 and we get the mask with this size and the compose with 1000x1000
Expected vs. Observed
| - | - |
|---|---|
| Expected | Receive the mask 1000x1000. |
| Observed | Receive the mask 2000x2000. |
Repro Steps
- Open, ripe-white-sbx https://ripe-white-sbx.platforme.com/?brand=dior_tmp&model=book_tote
- Open the inspect/ Network and choose images
- Refresh the page and see the requests mask and compose
- if you compare the masks images with the compose images you will see that have different sizes
Environment
| Key | Value |
|---|---|
| Device | Desktop |
| Operating System | Ubuntu 21.04 |
| Browser | Chrome |
| Instance (URL) | https://ripe-core-sbx.platforme.com/api/mask?brand=dior_tmp&frame=side-0&model=book_tote |
Screens
API Mask request:
https://ripe-core-sbx.platforme.com/api/mask?brand=dior_tmp&frame=side-0&model=book_tote
API Compose request:
https://ripe-core-sbx.platforme.com/api/compose?brand=dior_tmp&debug=1&format=webp&frame=side-0&height=1000&model=book_tote&p=body%3Amesh_logo_mizza_dr%3Amizza&p=handle%3Amesh_logo_handle_mizza_dr%3Amizza&p=ribbon%3Across_stich_mizza_dr%3Amizza&p=shadow%3Adefault%3Adefault&width=1000
Woof, Woof!
Thank you for submitting the "API masks with the total image size" issue 😎.
⚡ Tobias has found some errors ⚡
- Either
bugorenhancementlabel must be set
Please do not forget to review our internal guidelines:
- Describe the problem in the best possible way
- Include at least the
Descriptionsection, but considered adding other sections - Avoid suggesting immediate solutions, think deeply about the problem
- Engage in the Triage process being as responsive as possible
- Understand and accept the possibly large amount of execution time
- Avoid immediate reallocation of the issue, let triage do their job
Engaging in the development process in the best possible way helps it being efficient and fast.
Your friend,
Tobias (Platforme's mascot)
Server-side: enhance the masks endpoint to be able to handle size
Client-side: start using the new size parameter
Missing support for SDK + white
@dsafonso Ready to be tested