Report URLs methods not accepting params
NFSS10 opened this issue · 1 comments
NFSS10 commented
Description
The methods _getOrderReportURL
, _getOrderReportPDFURL
and _getOrderReportPNGURL
aren't correctly handling params
as they are being ignored and not properly added to the URL.
The methods sould be fixed and the tests updated to catch those cases.
Expected vs. Observed
- | - |
---|---|
Expected | Calling _getOrderReportPNGURL(1234, "secret-key", { params: { size: 100 } }); should return orders/1234/report.png?key=secret-key&size=100 |
Observed | Calling _getOrderReportPNGURL(1234, "secret-key", { params: { size: 100 } }); returns orders/1234/report.png?key=secret-key |
Repro Steps
- Use one of those methods with
params
passed tooptions
- Check that the
params
are ignored
Environment
Key | Value |
---|---|
Device | Any |
Operating System | Any |
Browser | Any |
dsafonso commented