ripe-tech/ripe-sdk

No masks options disable highlighting but masks are still loaded

Closed this issue · 2 comments

joao-conde commented

Description

Through the use of noMasks or useMasks one can control whether the masks are used. However, even when not using them, the SDK still loads them and these represent a significant amount of network requests. We should not load masks if they are not going to be used.

Expected vs. Observed

- -
Expected The masks are show and not loaded i.e. no network requests for masks are made.
Observed The masks are not shown but are loaded and you can see it in the network requests.

Repro Steps

  1. Initialize our RIPE in this repo
  2. Set useMasks: false or noMasks: true in the bindConfigurator method
  3. Build the SDK, launch the demo, go to localhost:8080/simple network tab

Screens

image

ripe-tobias-bot commented

Woof, Woof!

Thank you @joao-conde for submitting the "No masks options disable highlighting but masks are still loaded" issue 😎.

Please do not forget to review our internal guidelines:

  • Describe the problem in the best possible way
  • Include at least the Description section, but considered adding other sections
  • Avoid suggesting immediate solutions, think deeply about the problem
  • Engage in the Triage process being as responsive as possible
  • Understand and accept the possibly large amount of execution time
  • Avoid immediate reallocation of the issue, let triage do their job

Engaging in the development process in the best possible way helps it being efficient and fast.

Your friend,
Tobias (Platforme's mascot)

Tobias Bot

msp-platforme commented

👍
When masks are on (parameter use_masks=1) we see a lot of network requests and we can also hover the model and see the masks.
image

When masks are off (parameter use_masks=0) we don't see network requests related to maks and we if we hover the model it does not have masks.
image