ripose-jp/Memento

SubtitleParser acceptable encodings?

Calvin-Xu opened this issue · 2 comments

Calvin-Xu commented

I had a subtitle file in UTF-16 LE (SRT), and the parser fails immediately at the leading position (SRT Parser: Invalid position "��1"). Since mpv accepts subtitles in this encoding with no problem, maybe this can be addressed?

Also, may I suggest also printing the line number where it encounters an error in addition to printing the line out to help the user locate and fix the subtitle file?

ripose-jp commented

Could you link me to an SRT file that does this?

Also, may I suggest also printing the line number where it encounters an error in addition to printing the line out to help the user locate and fix the subtitle file?

This probably won't be difficult, but I'll have to check when I fix this.

Calvin-Xu commented

This one does it on latest built of master.

Patlabor_the_Movie_2_(1993)[720p,BluRay,x264]-_THORA.txt

This probably won't be difficult, but I'll have to check when I fix this.

Thanks. I just added a counter for tracking down this issue. Should not be too bad.